You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/25 12:29:27 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request #6438: support mysql insert select statement route and rewrite

strongduanmu opened a new pull request #6438:
URL: https://github.com/apache/shardingsphere/pull/6438


   Fixes #6289 .
   
   Changes proposed in this pull request:
   - support mysql insert select statement route and rewrite
   - add some rewrite test cases
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu commented on pull request #6438: support mysql insert select statement route and rewrite

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #6438:
URL: https://github.com/apache/shardingsphere/pull/6438#issuecomment-664109110


   > @strongduanmu @terrymanu has no problem with it. Please think about it. :)
   
   Thank you very much for confirming, I will optimize it. 😀


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #6438: support mysql insert select statement route and rewrite

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6438:
URL: https://github.com/apache/shardingsphere/pull/6438#issuecomment-664098966


   Another improvement we can consider is moving checking logics of `route()` in `ShardingStandardRoutingEngine` to `ShardingStatementValidator`. Besides, do you think it will become better to pass `SQLStatementContext` instead of `SQLStatement` to it? If so, `tableContexts` is possible to remove from the parameter list of `validate()`.
   
   Since this interface was created by @terrymanu  , I will ask him for advice ASAP.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #6438: support mysql insert select statement route and rewrite

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6438:
URL: https://github.com/apache/shardingsphere/pull/6438


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on pull request #6438: support mysql insert select statement route and rewrite

Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #6438:
URL: https://github.com/apache/shardingsphere/pull/6438#issuecomment-664107850


   @strongduanmu @terrymanu has no problem with it. Please think about it. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org