You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Dain Sundstrom (JIRA)" <ji...@apache.org> on 2007/02/22 01:27:03 UTC
[jira] Created: (AMQ-1165) RegionBroker resets JMS Timestamp
RegionBroker resets JMS Timestamp
---------------------------------
Key: AMQ-1165
URL: https://issues.apache.org/activemq/browse/AMQ-1165
Project: ActiveMQ
Issue Type: Bug
Affects Versions: 4.1.0
Reporter: Dain Sundstrom
Attachments: Timestamp.patch
The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.
if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) {
//timestamp not been disabled and has not passed through a network
message.setTimestamp(System.currentTimeMillis());
}
Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (AMQ-1165) RegionBroker resets JMS Timestamp
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino reassigned AMQ-1165:
----------------------------------
Assignee: Hiram Chirino
> RegionBroker resets JMS Timestamp
> ---------------------------------
>
> Key: AMQ-1165
> URL: https://issues.apache.org/activemq/browse/AMQ-1165
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Dain Sundstrom
> Assigned To: Hiram Chirino
> Attachments: Timestamp.patch
>
>
> The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.
> if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) {
> //timestamp not been disabled and has not passed through a network
> message.setTimestamp(System.currentTimeMillis());
> }
> Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1165) RegionBroker resets JMS Timestamp
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_38607 ]
Hiram Chirino commented on AMQ-1165:
------------------------------------
Your right.. corrected in rev 512102 and 512104
> RegionBroker resets JMS Timestamp
> ---------------------------------
>
> Key: AMQ-1165
> URL: https://issues.apache.org/activemq/browse/AMQ-1165
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Dain Sundstrom
> Assigned To: Hiram Chirino
> Fix For: 4.1.1, 4.2.0
>
> Attachments: Timestamp.patch
>
>
> The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.
> if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) {
> //timestamp not been disabled and has not passed through a network
> message.setTimestamp(System.currentTimeMillis());
> }
> Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1165) RegionBroker resets JMS Timestamp
Posted by "Dain Sundstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_38605 ]
Dain Sundstrom commented on AMQ-1165:
-------------------------------------
I think you forgot to commit the test case.
> RegionBroker resets JMS Timestamp
> ---------------------------------
>
> Key: AMQ-1165
> URL: https://issues.apache.org/activemq/browse/AMQ-1165
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Dain Sundstrom
> Assigned To: Hiram Chirino
> Fix For: 4.1.1, 4.2.0
>
> Attachments: Timestamp.patch
>
>
> The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.
> if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) {
> //timestamp not been disabled and has not passed through a network
> message.setTimestamp(System.currentTimeMillis());
> }
> Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1165) RegionBroker resets JMS Timestamp
Posted by "Jason Dillon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_38566 ]
Jason Dillon commented on AMQ-1165:
-----------------------------------
Has anyone had a chance to look at this? This is a blocking issue for release of Geronimo 1.2 due to TCK certification...
> RegionBroker resets JMS Timestamp
> ---------------------------------
>
> Key: AMQ-1165
> URL: https://issues.apache.org/activemq/browse/AMQ-1165
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Dain Sundstrom
> Attachments: Timestamp.patch
>
>
> The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.
> if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) {
> //timestamp not been disabled and has not passed through a network
> message.setTimestamp(System.currentTimeMillis());
> }
> Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1165) RegionBroker resets JMS Timestamp
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_38573 ]
Hiram Chirino commented on AMQ-1165:
------------------------------------
That logic was put in place as a "Feature".. In rev 511463 in 4.1 trunk I have now made that "Feature" optional so that we don't break JMS compliance.
> RegionBroker resets JMS Timestamp
> ---------------------------------
>
> Key: AMQ-1165
> URL: https://issues.apache.org/activemq/browse/AMQ-1165
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Dain Sundstrom
> Assigned To: Hiram Chirino
> Attachments: Timestamp.patch
>
>
> The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.
> if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) {
> //timestamp not been disabled and has not passed through a network
> message.setTimestamp(System.currentTimeMillis());
> }
> Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (AMQ-1165) RegionBroker resets JMS Timestamp
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino resolved AMQ-1165.
--------------------------------
Resolution: Fixed
Fix Version/s: 4.2.0
4.1.1
> RegionBroker resets JMS Timestamp
> ---------------------------------
>
> Key: AMQ-1165
> URL: https://issues.apache.org/activemq/browse/AMQ-1165
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Dain Sundstrom
> Assigned To: Hiram Chirino
> Fix For: 4.1.1, 4.2.0
>
> Attachments: Timestamp.patch
>
>
> The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.
> if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) {
> //timestamp not been disabled and has not passed through a network
> message.setTimestamp(System.currentTimeMillis());
> }
> Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (AMQ-1165) RegionBroker resets JMS Timestamp
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-1165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_38574 ]
Hiram Chirino commented on AMQ-1165:
------------------------------------
also fixed in trunk rev 511464
> RegionBroker resets JMS Timestamp
> ---------------------------------
>
> Key: AMQ-1165
> URL: https://issues.apache.org/activemq/browse/AMQ-1165
> Project: ActiveMQ
> Issue Type: Bug
> Affects Versions: 4.1.0
> Reporter: Dain Sundstrom
> Assigned To: Hiram Chirino
> Fix For: 4.1.1, 4.2.0
>
> Attachments: Timestamp.patch
>
>
> The RegionBroker contains the following logic, which overwrites the JMSTimestamp. FWIU, the message timestamp should be set once at send and never changed by the broker.
> if (message.getTimestamp() > 0 && (message.getBrokerPath() == null || message.getBrokerPath().length == 0)) {
> //timestamp not been disabled and has not passed through a network
> message.setTimestamp(System.currentTimeMillis());
> }
> Attached is a simple test case and patch that changes the '>' in the if statement above to '<='. I'm not sure if that is the proper fix, but it did make my problem go away.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.