[GitHub] [iceberg] findepi commented on a change in pull request #3815: API: Upgrade Guava to use murmur3_32_fixed

[GitBox <gi...@apache.org>]

findepi commented on a change in pull request #3815:
URL: https://github.com/apache/iceberg/pull/3815#discussion_r776712584



##########
File path: api/src/main/java/org/apache/iceberg/transforms/Bucket.java
##########
@@ -41,7 +41,7 @@
 import static org.apache.iceberg.types.Type.TypeID;
 
 abstract class Bucket<T> implements Transform<T, Integer> {
-  private static final HashFunction MURMUR3 = Hashing.murmur3_32();
+  private static final HashFunction MURMUR3 = Hashing.murmur3_32_fixed();

Review comment:
       We should have hash stability tests to ensure hash values don't change. See https://github.com/trinodb/trino/blob/863da2b2d3f92dd858e028d30ceb63184dfb515d/plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergBucketing.java#L122 for example.
   
   This can be followed up upon, for now we can rely on @wendigo's test in Trino.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org