You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/08/25 16:30:13 UTC

[GitHub] [incubator-pinot] suvodeep-pyne commented on pull request #5868: [TE] Added support for BigQuery as data source

suvodeep-pyne commented on pull request #5868:
URL: https://github.com/apache/incubator-pinot/pull/5868#issuecomment-680133351


   Hi @cyrilou242 
   
   Thanks for the contribution! 
   - How to build docs: https://github.com/apache/incubator-pinot/blob/master/thirdeye/docs/README.md
   - What are the advantages of choosing a JDBC client over a REST Client?
   - Correct me if I'm wrong here: the core code change that I see here is the timestamp translation?
   - Apart dependencies, what are other issues of plugging in the BigQuery JDBC driver?
   - ThirdEye has a lot of dependencies. Would be great to cleanup. But can be done as a separate PR?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org