You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/18 23:24:42 UTC

[GitHub] [pulsar-client-go] WIZARDISHUNGRY commented on issue #228: ClientOptions should get a Logger field to allow injecting of an external Logger

WIZARDISHUNGRY commented on issue #228:
URL: https://github.com/apache/pulsar-client-go/issues/228#issuecomment-630486009


   It may be preferable to allow injection of an interface as a logger ([like this](https://github.com/dexidp/dex/blob/master/pkg/log/logger.go)) but we'd lose the structured logging features. We use logrus most places right now, so even allowing us to inject our own logrus would help as a first step.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org