You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/04 15:05:43 UTC
[GitHub] [shardingsphere] zjcnb opened a new issue #15800: The `ReadwriteSplittingDataSourceRuleConfiguration` need add unit test
zjcnb opened a new issue #15800:
URL: https://github.com/apache/shardingsphere/issues/15800
Hi community,
This issue is for [OpenForce](https://github.com/apache/shardingsphere/discussions/12683#discussioncomment-2139441)
ReadwriteSplittingDataSourceRuleConfiguration need some unit test.
- [ ] ReadwriteSplittingDataSourceRuleConfiguration.getAutoAwareDataSourceName()
- [ ] ReadwriteSplittingDataSourceRuleConfiguration.getWriteDataSourceName()
- [ ] ReadwriteSplittingDataSourceRuleConfiguration.getReadDataSourceNames()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss commented on issue #15800: The `ReadwriteSplittingDataSourceRuleConfiguration` need add unit test
Posted by GitBox <gi...@apache.org>.
menghaoranss commented on issue #15800:
URL: https://github.com/apache/shardingsphere/issues/15800#issuecomment-1059904340
@shreya024 please refer to `ReadwriteSplittingRuleTest` as an example, just create an object through `new ReadwriteSplittingDataSourceRuleConfiguration`, and then assert whether the value obtained by the above method is the same as you expect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shreya024 commented on issue #15800: The `ReadwriteSplittingDataSourceRuleConfiguration` need add unit test
Posted by GitBox <gi...@apache.org>.
shreya024 commented on issue #15800:
URL: https://github.com/apache/shardingsphere/issues/15800#issuecomment-1059785270
Hi, I am Shreya, a contributor to OpenForce 2022. I would like to work on this issue. I would be making a PR as soon as I am done with resolving the issue. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o closed issue #15800: The `ReadwriteSplittingDataSourceRuleConfiguration` need add unit test
Posted by GitBox <gi...@apache.org>.
yx9o closed issue #15800:
URL: https://github.com/apache/shardingsphere/issues/15800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #15800: The `ReadwriteSplittingDataSourceRuleConfiguration` need add unit test
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #15800:
URL: https://github.com/apache/shardingsphere/issues/15800#issuecomment-1059851164
@shreya024 Welcome, I will assign this issue to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org