You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/01/17 14:49:54 UTC
[GitHub] [httpcomponents-client] ok2c opened a new pull request #278: Package and publish reports as versioned artifact
ok2c opened a new pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-769321739
@hboutemy I find it quite perplexing that you object to publishing **_one_** extra release artifact yet you do not seem to have any issue with the idea of having to make a **_full new release_** with a whole bunch of useless artifacts just to be able to update some content on the project web site.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761856333
I don't like that at all
if you want to keep versioned content, you can do it in the site: this would be an added benefit to the work that will be required after the first pass at testing
if you had published content to https://hc.apache.org/httpcomponents-client-5.0.x/doc/ as I asked many times in #277 , we could have worked on this for a long time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761888428
> publising SNAPSHOT content to the productive website for testing purposes is the right way but publishing versioned and approved by a vote release artifact to the artifact repository is not the right way?
to keep it short, yes
> Please proceed with your plan
yes: please proceed with the next step of the plan = publish to https://hc.apache.org/httpcomponents-client-5.0.x/doc/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-768473098
>
>
> @hboutemy @michael-o I hope we can still discuss the overall strategy at the ML at some point. In the meantime I will merge this PR and proceed with the 5.1 beta releases of core and client.
I absolutely intend to, but cannot do anything at the moment. I hope a get some spare time next week for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761862052
@hboutemy I understand you do not like it. There are many, many things I do not like too but I am trying to stay constructive.
5MB per release is _nothing_ in terms of storage. I do not see this as a strong argument.
Why have you been expecting me to push SNAPSHOT content to our productive website? This makes no sense. I published it as per your instructions to the staging directory, reviewed it and immediately reported back to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c closed pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c closed pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-768845463
sorry, this week has been really busy: I'll find time tomorrow and over the WE
please don't merge this PR, as going through a zip file in Maven Central to finallly upload html content to your site is really not something to do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] michael-o commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-763485759
I am currently sorry that I cannot participate at all, but my current situation leaves me no choice unfortunately. @hboutemy Thank you very much for the time your invest into this. If this approach is just like as for Maven TLP then this is a very decent approach and @ok2c you always can stage to `*-LATEST` and then push to production. I hope Hervé made it that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-762076492
@hboutemy Thank you for your contribution so far, but the overall approach where you get to decide what the right way is and to dictate what other people must do is not very helpful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-764982470
> you always can stage to `*-LATEST` and then push to production. I hope Hervé made it that way.
currently, I only did a proof of concept, choosing a `doc` directory name that is causing confusion on its intent
switching to LATEST requires:
1. explanations (I didn't have time yet), because it's not obvious
2. separation of the equivalent of `/components` directory in Maven, which requires also explanations...
I promise I'll send explanations on the ML, I hope I'll have time this WE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761824813
@michael-o @garydgregory @hboutemy I would like to start publishing project reports as versioned artifacts. At a cost of 5MB zip file in artifactory we would have an option of deploying release reports at any point of time. If you see ways of optimizing the assembly process do feel free to let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy edited a comment on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-769646388
so much misundestanding: I won't argue, lost time for both of us (and I don't blame any of us: convergence of mind is not easy, I'm sure you are making as many efforts as I do)
I chose to use my time preparing the next steps:
- improving http-client solution to remove one source of misunderstanding through PR #280
- doing the same for http-core, given you asked for it: PR https://github.com/apache/httpcomponents-core/pull/252
- gluing everything in the website: PR https://github.com/apache/httpcomponents-website/pull/9
please review, question, ideally merge and execute scm-publish on http-core and http-client (it is already automatically done on website through Jenkins)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-768462018
@hboutemy @michael-o I hope we can still discuss the overall strategy at the ML at some point. In the meantime I will merge this PR and proceed with the 5.1 beta releases of core and client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy edited a comment on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761856333
I don't like that at all: storing unused generated content to Maven Central just adds unused storage
if you want to keep versioned content, you can do it in the site: this would be an added benefit to the work that will be required after the first pass at testing
if you had published content to https://hc.apache.org/httpcomponents-client-5.0.x/doc/ as I asked many times in #277 , we could have worked on this for a long time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-763477031
@hboutemy So, it is not the content you want published but rather the publishing mechanism tested? I still think it would be wrong to use the productive website for that end. Is there a staging repo we could use instead? If not, may I suggest that we use the next HttpCore 5.1 beta release to test `scm-publish` with proper release content? Could we focus on working out the content management aspects first and deal with transport aspects later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-769646388
so much misundestanding: I won't argue, lost time for both of us (and I don't blame any of us: convergence of mind is not easy, I'm sure you are making as many efforts as I do)
I chose to use my time preparing the next steps:
- improving http-client solution to remove one source of misunderstanding through PR #280
- doing the same for http-core, given you asked for it: PR https://github.com/apache/httpcomponents-core/pull/252
- gluing everything in the website: PR https://github.com/apache/httpcomponents-website/pull/9
please review, question, ideally merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761873950
@hboutemy Let me make sure I understand it correctly: publising SNAPSHOT content to the productive website for testing purposes is the right way but publishing versioned and approved by a vote release artifact to the artifact repository is not the right way?
I think the project team members are perfectly capable of executing `mvn clean site site:stage`.
Please proceed with your plan. This change does not negate anything done so far nor does it prevent you from progressing with your plan.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-765182182
@ok2c
> So, it is not the content you want published but rather the publishing mechanism tested?
in fact, both are important:
- content, because it's while it is SNAPSHOT that we can improve it: when the source release will be done, documentation will be versioned and any idea of improvement will be a source of frustration, because it will require to wait for next source release
- publishing mechanism, because this is where the most discovery and learning is necessary
> I still think it would be wrong to use the productive website for that end. Is there a staging repo we could use instead?
in fact, current `doc` directory is a staging directory (and can be renamed after the PoC): it is intended to be updated when useful to see latest result, and as a staging area when a release is under vote.
Once the vote is ok, it will be copied to a versioned directory with `svn cp`, to keep the state of the documentation at the release time as the definitive release documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761869079
and saying that saving content to Maven Central is not the right way for you to keep versioned your content in your site is meant to be constructive
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-763187750
let's cool down, there is misunderstanding
what needs to be tested and learned is the scm-publish part
```
mvn scm-publish:publish-scm
```
in parallel, I'll send on the ML analysis of what remains to be done to go from this PoC state to something that will work for future releases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-764982470
> you always can stage to `*-LATEST` and then push to production. I hope Hervé made it that way.
currently, I only did a proof of concept, choosing a `doc` directory name that is causing confusion on its intent
switching to LATEST requires:
1. explanations (I didn't have time yet), because it's not obvious
2. separation of the equivalent of `/components` directory in Maven, which requires also explanations...
I promise I'll send explanations on the ML, I hope I'll have time this WE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761868332
because testing makes sense, and not only testing for 1 user but for the whole team (I hope you're not alone): it'll be in the future that content will be for release
and at that time there will be the question of having both last release and future SNAPSHOT for testing
I'm trying to go step by step, trying you to get experience, because previously I explained some plan, but it was too complex
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-769933795
@hboutemy All right. Let's just stick to the task at hand for now. I will merge those PRs as soon as they pass all the checks.
In the meantime I also realized I could pull javadocs and sources (albeit un-formatted) from the artifact repository already and generate API compatibility reports with JApiCmp reports dynamically with published artifacts. That is enough for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] hboutemy edited a comment on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
hboutemy edited a comment on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-768845463
sorry, this week has been really busy: I'll find time tomorrow and over the WE
please don't merge this PR, as going through a zip file in Maven Central to finallly upload html content to manually inject to your site is really not something to do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c edited a comment on pull request #278: Package and publish reports as versioned artifact
Posted by GitBox <gi...@apache.org>.
ok2c edited a comment on pull request #278:
URL: https://github.com/apache/httpcomponents-client/pull/278#issuecomment-761824813
@michael-o @garydgregory @hboutemy I would like to start publishing project reports as versioned artifacts. At a cost of 5MB zip file in the artifact repository we would have an option of deploying release reports at any point of time. If you see ways of optimizing the assembly process do feel free to let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org