You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/06 12:40:18 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #10803: chore: deprecate python 3.6 support
villebro opened a new pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803
### SUMMARY
With Python 3.7 having been released over 2 years ago and recently [entered 'security fix'](https://www.python.org/downloads/release/python-379/) mode, along with the [`dataclasses`](https://pypi.org/project/dataclasses/) backport package no longer supporting Python 3.7 as of version 0.7, it's time to deprecate support for python 3.6 to be able to take full advantage of [new features in 3.7](https://realpython.com/python37-new-features/).
Changes introduced by this PR:
- removes 3.6 from the CI build matrix
- removes `dataclasses` dependency from `setup.py
- replaces Python 3.6 with 3.7 in all `Dockerfile`s
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
CI + local testing
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-690925616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
cyw233 commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-690923524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-688568511
Let's mention this in `UPDATING.md`!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-690925616
Good catch! I thought I got them all 🙁 Would you mind opening a PR to fix this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-687845082
Related INFRA ticket: https://issues.apache.org/jira/browse/INFRA-20823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-690925616
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
cyw233 commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-690923524
Thanks for the update! I think we also need to change these two lines to 3.7 in the Dockerfile. Cheers.
<img width="987" alt="to_37" src="https://user-images.githubusercontent.com/49756587/92882252-13cebc00-f453-11ea-9eb8-8ad4a063fd7c.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
cyw233 commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-690923524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] cyw233 commented on pull request #10803: chore: deprecate python 3.6 support
Posted by GitBox <gi...@apache.org>.
cyw233 commented on pull request #10803:
URL: https://github.com/apache/incubator-superset/pull/10803#issuecomment-690926233
Sure let me do it now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org