You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/09/22 20:19:46 UTC
Review Request 25898: AURORA-736 - Update committer docs with steps
for adding a gpg key
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25898/
-----------------------------------------------------------
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-736
https://issues.apache.org/jira/browse/AURORA-736
Repository: aurora
Description
-------
AURORA-736 - Update committer docs with steps for adding a gpg key
Diffs
-----
docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96
Diff: https://reviews.apache.org/r/25898/diff/
Testing
-------
Thanks,
Jake Farrell
Re: Review Request 25898: AURORA-736 - Update committer docs with
steps for adding a gpg key
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25898/#review54195
-----------------------------------------------------------
Ship it!
Ship It!
docs/committers.md
<https://reviews.apache.org/r/25898/#comment94190>
s/Adding/Add/
docs/committers.md
<https://reviews.apache.org/r/25898/#comment94191>
s/Adding/Add/
- Kevin Sweeney
On Sept. 22, 2014, 2:01 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25898/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 2:01 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-736
> https://issues.apache.org/jira/browse/AURORA-736
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-736 - Update committer docs with steps for adding a gpg key
>
>
> Diffs
> -----
>
> docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96
>
> Diff: https://reviews.apache.org/r/25898/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 25898: AURORA-736 - Update committer docs with
steps for adding a gpg key
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25898/
-----------------------------------------------------------
(Updated Sept. 22, 2014, 9:01 p.m.)
Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-736
https://issues.apache.org/jira/browse/AURORA-736
Repository: aurora
Description
-------
AURORA-736 - Update committer docs with steps for adding a gpg key
Diffs (updated)
-----
docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96
Diff: https://reviews.apache.org/r/25898/diff/
Testing
-------
Thanks,
Jake Farrell
Re: Review Request 25898: AURORA-736 - Update committer docs with
steps for adding a gpg key
Posted by Jake Farrell <jf...@apache.org>.
> On Sept. 22, 2014, 6:23 p.m., Kevin Sweeney wrote:
> > docs/committers.md, line 29
> > <https://reviews.apache.org/r/25898/diff/1/?file=699661#file699661line29>
> >
> > add a mention of git config user.signingkey here too?
Good call, the release scripts do check and print out an error msg if this step is missed. patch updated.
- Jake
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25898/#review54152
-----------------------------------------------------------
On Sept. 22, 2014, 9:01 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25898/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 9:01 p.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-736
> https://issues.apache.org/jira/browse/AURORA-736
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-736 - Update committer docs with steps for adding a gpg key
>
>
> Diffs
> -----
>
> docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96
>
> Diff: https://reviews.apache.org/r/25898/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 25898: AURORA-736 - Update committer docs with
steps for adding a gpg key
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25898/#review54152
-----------------------------------------------------------
docs/committers.md
<https://reviews.apache.org/r/25898/#comment94151>
add a mention of git config user.signingkey here too?
- Kevin Sweeney
On Sept. 22, 2014, 11:19 a.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25898/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 11:19 a.m.)
>
>
> Review request for Aurora, Dave Lester, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-736
> https://issues.apache.org/jira/browse/AURORA-736
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-736 - Update committer docs with steps for adding a gpg key
>
>
> Diffs
> -----
>
> docs/committers.md 3f68f89f921e1e17e6eb53ef13c550b3e52fce96
>
> Diff: https://reviews.apache.org/r/25898/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jake Farrell
>
>