You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@distributedlog.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/05 21:57:58 UTC
[jira] [Commented] (DL-173) Test fail on Windows - Unable to delete
directory
[ https://issues.apache.org/jira/browse/DL-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15802644#comment-15802644 ]
ASF GitHub Bot commented on DL-173:
-----------------------------------
GitHub user adamtracymartin opened a pull request:
https://github.com/apache/incubator-distributedlog/pull/101
DL-173: changed FileUtiles.deleteDirectory to FileUtiles.forceDeleteOnExit so files would delete on Windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adamtracymartin/incubator-distributedlog DL-173
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-distributedlog/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
commit 4d4153c7bc8f021fd141ab1dbae6f4a4732c9569
Author: adamtracymartin <at...@yahoo.com>
Date: 2017-01-05T21:49:54Z
changed FileUtiles.deleteDirectory to FileUtiles.forceDeleteOnExit so files would delete on Windows
commit c80a4d82603c1553121cf48d9447da7945f2d899
Author: Tracy Martin <at...@yahoo.com>
Date: 2017-01-05T21:55:01Z
I did not mean to check in the .checkstyle files
commit 6e8e23ab065114d0d5cdad97759f2d0b5918de46
Author: Tracy Martin <at...@yahoo.com>
Date: 2017-01-05T21:55:28Z
I did not mean to check in the .checkstyle file.
----
> Test fail on Windows - Unable to delete directory
> -------------------------------------------------
>
> Key: DL-173
> URL: https://issues.apache.org/jira/browse/DL-173
> Project: DistributedLog
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Tracy Martin
> Assignee: Tracy Martin
> Priority: Minor
>
> When running "mvn clean test", some of the tests fail because a directory cannot be deleted.
> An example:
> java.io.IOException: Unable to delete file: C:\Users\TRACYM~1\AppData\Local\Temp\zookeeper6811260662521660350com.twitter.distributedlog.ZooKeeperClusterTestCase\version-2\log.1
> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1919)
> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1399)
> at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1331)
> at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:1910)
> at org.apache.commons.io.FileUtils.cleanDirectory(FileUtils.java:1399)
> at org.apache.commons.io.FileUtils.deleteDirectory(FileUtils.java:1331)
> at com.twitter.distributedlog.ZooKeeperClusterTestCase.shutdownZooKeeper(ZooKeeperClusterTestCase.java:50)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
> at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
> at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
> at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:37)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
> at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
> at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:123)
> at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:104)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:164)
> at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:110)
> at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:172)
> at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcessWhenForked(SurefireStarter.java:78)
> at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:70)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)