[jira] [Commented] (OFBIZ-9623) Improvements in LabelReferences class

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142096#comment-16142096 ] 

Jacques Le Roux commented on OFBIZ-9623:
----------------------------------------

Thanks Suraj,

I reviewed and this seems good to me. But I currently can't test because no languages are available in webtools/control/SearchLabels. I guess it's due to the recent changes introduced for the themes, unsure about that yet. Same for OFBIZ-9606


> Improvements in LabelReferences class
> -------------------------------------
>
>                 Key: OFBIZ-9623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9623
>             Project: OFBiz
>          Issue Type: Improvement
>            Reporter: Suraj Khurana
>            Assignee: Jacques Le Roux
>         Attachments: OFBIZ-9623.patch
>
>
> For Java:
> Current support is only for occurrences like "UtilProperties.getMessage(", but there are other occurrences such as "uiLabelMap.get(" in java as well. Need to add support for same.
> For groovy:
> After some recent improvements for groovy handling, still, there is a possibility that someone is using "UtilProperties.getMessage(" in groovy files as well, so IMO, that must also be handled.
> For XML forms:
> In XML forms current support in handled for auto-fields-service and auto-fields-entity but there are some occurrences of tooltip element of field tag as well, that must also be handled.
> For XML Simple Methods:
> Doesn't handle case of property-to-field and default-message elements. (Separate ticket created OFBIZ-9606, just adding it here for reference)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)