You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/29 19:04:49 UTC
[kudu-CR] env-test: add NO FATALS to create file and create dir calls
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8178
to review the following change.
Change subject: env-test: add NO_FATALS to create_file and create_dir calls
......................................................................
env-test: add NO_FATALS to create_file and create_dir calls
Change-Id: I872caa9b4347fc3dde04677235415c5149318eba
---
M src/kudu/util/env-test.cc
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/8178/1
--
To view, visit http://gerrit.cloudera.org:8080/8178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I872caa9b4347fc3dde04677235415c5149318eba
Gerrit-Change-Number: 8178
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] env-test: add NO FATALS to create file and create dir calls
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8178 )
Change subject: env-test: add NO_FATALS to create_file and create_dir calls
......................................................................
env-test: add NO_FATALS to create_file and create_dir calls
Change-Id: I872caa9b4347fc3dde04677235415c5149318eba
Reviewed-on: http://gerrit.cloudera.org:8080/8178
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/env-test.cc
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I872caa9b4347fc3dde04677235415c5149318eba
Gerrit-Change-Number: 8178
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] env-test: add NO FATALS to create file and create dir calls
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8178 )
Change subject: env-test: add NO_FATALS to create_file and create_dir calls
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8178
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I872caa9b4347fc3dde04677235415c5149318eba
Gerrit-Change-Number: 8178
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 29 Sep 2017 19:09:26 +0000
Gerrit-HasComments: No