[GitHub] [iceberg] singhpk234 commented on a diff in pull request #7353: Core, Spark: Make ObjectStoreLocationProvider serializable

["singhpk234 (via GitHub)" <gi...@apache.org>]

singhpk234 commented on code in PR #7353:
URL: https://github.com/apache/iceberg/pull/7353#discussion_r1167988162


##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -109,7 +109,7 @@ static class ObjectStoreLocationProvider implements LocationProvider {
 
     private static final HashFunction HASH_FUNC = Hashing.murmur3_32_fixed();
     private static final BaseEncoding BASE64_ENCODER = BaseEncoding.base64Url().omitPadding();
-    private final ThreadLocal<byte[]> temp = ThreadLocal.withInitial(() -> new byte[4]);
+    private transient ThreadLocal<byte[]> temp;

Review Comment:
   nice suggesgtion made the changes !



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org