You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/09/06 13:06:46 UTC
[GitHub] [shardingsphere] ccMoriarty opened a new issue #12245: support proxy's "set names"
ccMoriarty opened a new issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245
### Describe the feature you would like.
now, "set names" is actually a transparent transmission, to execute "set names" on the specific DB. it changes the character set of DB，not the ShardingSphere-proxy.
When a SQL is executed, it reaches the proxy first, and the proxy will convert it from byte stream to String. Now there is no specified character set.This may cause chinese garbled problems.
if i have a gbk table and a utf8 table in same proxy, it must cause chinese garbled.
so i think proxy's "set names" can be supported. in mysql, set names changes the session-level character set. I hope the proxy has its own session-level character set. (When new String, the specified Session-level character set that can be displayed)
if it is completed, we can use multiple encoding formats in one proxy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN closed issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
TeslaCN closed issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-914907917
So do we have any guides to help contributors raise a PR on this issue? @RaigorJiang
@ccMoriarty Would you like to try to fix this issue with a hand from our committer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-995490533
Hi @ccMoriarty
The Proxy has supported session-level charset since #13332. Would you like to finish this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ccMoriarty commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
ccMoriarty commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-995504640
@TeslaCN
I’m glad to to solve this problem. But it’s almost the end of the year, I’m busy here. it may have to wait until January to develop
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-1014088936
Hi @ccMoriarty
Any update here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-914913603
Currently, we do not maintain the character set in the metadata. In particular, it is a greater challenge for the Proxy to want a session-level character set.
Therefore, this work may have a relatively large impact and requires thinking and design first.
If @ccMoriarty is interested, please put forward some ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-1080133437
This issue has been fixed in #15603, #15619, #15753, #15795.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-914907917
So do we have any guides to help contributors raise a PR on this issue? @RaigorJiang
@ccMoriarty Would you have to try to fix this issue with a hand from our committer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-913743505
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-946459429
@ccMoriarty
Looking forward to your PR, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ccMoriarty commented on issue #12245: support proxy's "set names"
Posted by GitBox <gi...@apache.org>.
ccMoriarty commented on issue #12245:
URL: https://github.com/apache/shardingsphere/issues/12245#issuecomment-946451689
i will try to fix it in my free time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org