You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chenghao-intel <gi...@git.apache.org> on 2014/12/19 12:36:52 UTC
[GitHub] spark pull request: [SPARK-4901] [SQL] Hot fix for ByteWritables.c...
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/3742
[SPARK-4901] [SQL] Hot fix for ByteWritables.copyBytes
HiveInspectors.scala failed in compiling with Hadoop 1, as the BytesWritable.copyBytes is not available in Hadoop 1.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenghao-intel/spark settable_oi_hotfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3742.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3742
----
commit bb04d1f8a8ed2ae521f95694e9df4e75cbd7c512
Author: Cheng Hao <ha...@intel.com>
Date: 2014-12-19T11:23:56Z
hot fix for ByteWritables.copyBytes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4901] [SQL] Hot fix for ByteWritables.c...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3742#issuecomment-67657107
LGTM. It looks like this properly uses `getBytes()` by also using `getLength()` to determine which subarray of the `getBytes()` result contains valid data (see [HADOOP-6298](https://issues.apache.org/jira/browse/HADOOP-6298)).
I suppose this could use `Arrays.copyOfRange` to cut out one line (like was done in https://github.com/apache/spark/commit/fc616d51a510f82627b5be949a5941419834cf70#diff-364713d7776956cb8b0a771e9b62f82dR1435), but that's just a minor thing, so I'm going to merge this to fix the Hadoop 1 build. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4901] [SQL] Hot fix for ByteWritables.c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4901] [SQL] Hot fix for ByteWritables.c...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3742#issuecomment-67628335
[Test build #24641 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24641/consoleFull) for PR 3742 at commit [`bb04d1f`](https://github.com/apache/spark/commit/bb04d1f8a8ed2ae521f95694e9df4e75cbd7c512).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4901] [SQL] Hot fix for ByteWritables.c...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3742#issuecomment-67634092
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24641/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-4901] [SQL] Hot fix for ByteWritables.c...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3742#issuecomment-67634089
[Test build #24641 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24641/consoleFull) for PR 3742 at commit [`bb04d1f`](https://github.com/apache/spark/commit/bb04d1f8a8ed2ae521f95694e9df4e75cbd7c512).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org