You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2023/02/15 00:23:07 UTC

[spark] branch master updated: [SPARK-42342][PYTHON][CONNECT][TEST] Fix FunctionsParityTests.test_raise_error to call the proper test

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 3ed1b951386 [SPARK-42342][PYTHON][CONNECT][TEST] Fix FunctionsParityTests.test_raise_error to call the proper test
3ed1b951386 is described below

commit 3ed1b9513867e4d5bcf048f3042a91ffd3524771
Author: Takuya UESHIN <ue...@databricks.com>
AuthorDate: Wed Feb 15 09:22:55 2023 +0900

    [SPARK-42342][PYTHON][CONNECT][TEST] Fix FunctionsParityTests.test_raise_error to call the proper test
    
    ### What changes were proposed in this pull request?
    
    This is a follow-up of #39882.
    
    Fixes `FunctionsParityTests.test_raise_error` to call the proper test.
    
    ### Why are the changes needed?
    
    `FunctionsParityTests.test_raise_error` should've called `check_raise_error`.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    The fixed test.
    
    Closes #40021 from ueshin/issues/SPARK-42342/test.
    
    Authored-by: Takuya UESHIN <ue...@databricks.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 python/pyspark/sql/tests/connect/test_parity_functions.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/python/pyspark/sql/tests/connect/test_parity_functions.py b/python/pyspark/sql/tests/connect/test_parity_functions.py
index 3d390c13913..1ea33d2e370 100644
--- a/python/pyspark/sql/tests/connect/test_parity_functions.py
+++ b/python/pyspark/sql/tests/connect/test_parity_functions.py
@@ -54,7 +54,7 @@ class FunctionsParityTests(FunctionsTestsMixin, ReusedConnectTestCase):
         super().test_lit_np_scalar()
 
     def test_raise_error(self):
-        self.check_assert_true(SparkConnectException)
+        self.check_raise_error(SparkConnectException)
 
     # Comparing column type of connect and pyspark
     @unittest.skip("Fails in Spark Connect, should enable.")


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org