You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/19 16:05:15 UTC

[GitHub] [pulsar] gaoran10 opened a new pull request #8630: [Tiered Storage] Repair code for PR6335

gaoran10 opened a new pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630


   # Motivation
   
   The PR 6335 lost some PR changes, related PRs as below.
   
   1. PR 4196 (2019/5/29 Merli)
   Configure static PulsarByteBufAllocator to handle OOM errors (#4196)
   
   2. PR 5356 (2019/10/30 Kelly)
   [TIEREDSTORAGE] Only seek when reading unexpected entry (#5356)
   
   3. PR 4433 (2019/6/4 Higham)
   [tiered-storage] Add support for AWS instance and role creds (#4433)
   
   ### Modifications
   
   Repair the lost PR changes.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] jiazhai commented on pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630#issuecomment-730722346


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630#issuecomment-731497026


   /pulsarbot cherry-pick to branch-2.6


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630#issuecomment-731078942


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] gaoran10 commented on pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
gaoran10 commented on pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630#issuecomment-731344710


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] jiazhai commented on pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630#issuecomment-730722878


   @Renkai Would you please also help take a review of this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui commented on pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630#issuecomment-731498906


   cherry-picked to branch-2.6


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Renkai commented on pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
Renkai commented on pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630#issuecomment-730875857


   Test errors seems related to this PR @gaoran10 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] Renkai commented on pull request #8630: [Tiered Storage] Fix merge conflicts introduced by PR #6335

Posted by GitBox <gi...@apache.org>.
Renkai commented on pull request #8630:
URL: https://github.com/apache/pulsar/pull/8630#issuecomment-730800648


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org