You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by davies <gi...@git.apache.org> on 2014/10/25 01:00:40 UTC

[GitHub] spark pull request: [SPARK-4087] use broadcast for task only when ...

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2933#discussion_r19369470
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -124,6 +123,10 @@ class DAGScheduler(
       /** If enabled, we may run certain actions like take() and first() locally. */
       private val localExecutionEnabled = sc.getConf.getBoolean("spark.localExecution.enabled", false)
     
    +  /** Broadcast the serialized tasks only when they are bigger than it */
    +  private val broadcastTaskMinSize =
    +    sc.getConf.getInt("spark.scheduler.broadcastTaskMinSize", 8) * 1024
    --- End diff --
    
    As discussed offline, user will take the risk if they change it to non-reasonable values.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org