You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/04/23 05:30:08 UTC

[native-toolchain-CR] Add missing patch for orc 1.5.5

Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13082


Change subject: Add missing patch for orc 1.5.5
......................................................................

Add missing patch for orc 1.5.5

This change adds a patch that I had forgotten to add to this review:
https://gerrit.cloudera.org/#/c/12998/

I tested this locally by building the toolchain.

Change-Id: Iff84c883c50efdc6b438f5428e947ff0d0960ff8
---
A source/orc/orc-1.5.5-patches/0001-ORC-396-also-look-for-LZ4-libs-in-lib64-subdir.patch
1 file changed, 25 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/82/13082/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff84c883c50efdc6b438f5428e947ff0d0960ff8
Gerrit-Change-Number: 13082
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[native-toolchain-CR] Add missing patch for orc 1.5.5

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13082 )

Change subject: Add missing patch for orc 1.5.5
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff84c883c50efdc6b438f5428e947ff0d0960ff8
Gerrit-Change-Number: 13082
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 14:59:25 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Add missing patch for orc 1.5.5

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13082 )

Change subject: Add missing patch for orc 1.5.5
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff84c883c50efdc6b438f5428e947ff0d0960ff8
Gerrit-Change-Number: 13082
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 06:10:09 +0000
Gerrit-HasComments: No

[native-toolchain-CR] Add missing patch for orc 1.5.5

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13082 )

Change subject: Add missing patch for orc 1.5.5
......................................................................

Add missing patch for orc 1.5.5

This change adds a patch that I had forgotten to add to this review:
https://gerrit.cloudera.org/#/c/12998/

I tested this locally by building the toolchain.

Change-Id: Iff84c883c50efdc6b438f5428e947ff0d0960ff8
Reviewed-on: http://gerrit.cloudera.org:8080/13082
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
A source/orc/orc-1.5.5-patches/0001-ORC-396-also-look-for-LZ4-libs-in-lib64-subdir.patch
1 file changed, 25 insertions(+), 0 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Lars Volker: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13082
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff84c883c50efdc6b438f5428e947ff0d0960ff8
Gerrit-Change-Number: 13082
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>