[jira] [Comment Edited] (CALCITE-5000) Expand rule of `AGGREGATE_REDUCE_FUNCTIONS`, when arg of agg-call is in the aggregate's group

["Xurenhe (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17491863#comment-17491863 ] 

Xurenhe edited comment on CALCITE-5000 at 4/14/22 11:37 AM:
------------------------------------------------------------

Hi community
Take your time to review this [PR|http://[https://github.com/apache/calcite/pull/2714/files]]

Please tell me, If some cases of agg-call is missing.

Thanks a lot.


was (Author: wojustme):
Hi community
Take your time to review this issue

PR: [https://github.com/apache/calcite/pull/2714/files]

If not question, please ping me to rebase this pr.

Thanks a lot.

> Expand rule of `AGGREGATE_REDUCE_FUNCTIONS`, when arg of agg-call is in the aggregate's group
> ---------------------------------------------------------------------------------------------
>
>                 Key: CALCITE-5000
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5000
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Xurenhe
>            Assignee: Xurenhe
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> Using calcite's SubstitutionVisitor, we need do a lot work about canonicalizing relnode.
> Some sql should be simplified.
> {noformat}
> -- origin sql
> select deptno, salary, max(salary), min(commission) 
> from emps 
> group by deptno, salary
> -- simplified
> select deptno, salary, salary as expr, min(commission) 
> from emps 
> group by deptno, salary{noformat}
> It should be simplified, but I didn't find any rule to simplify it.
> This issue is related to CALCITE-4857



--
This message was sent by Atlassian Jira
(v8.20.1#820001)