You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2016/12/08 23:05:34 UTC
Review Request 54554: Do not assume std symbols are visible without
using FQN.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54554/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Repository: mesos
Description
-------
Some headers in libprocess contain using decls for names from the
standard namespace. This commit is a cleanup to allow us to remove
these globally visible using decls in a later commit.
In this commit we also add missing std includes for the touched
symbols.
Diffs
-----
src/slave/containerizer/mesos/isolators/gpu/isolator.hpp cd79033b24cd54e1b7e1c18beeb1629fc0f18537
src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
src/tests/command_executor_tests.cpp 63527863d3667bfd501b6da25e49bb22a65f9be0
src/tests/containerizer/appc_spec_tests.cpp f8fef884febb518249f94a395d4413bfc6be3e12
src/tests/containerizer/docker_tests.cpp 2f4e84ac10a00d59aa0b979055d5669ced4c895e
src/tests/containerizer/io_switchboard_tests.cpp 43f1ad6c13d25dca1e316ea9e622566a2af1c45d
src/tests/containerizer/nested_mesos_containerizer_tests.cpp 7744c83062cf30e515dd0a220c6080d63ba8c14d
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 74e06f0d588abc7423534a1e2a4050922cef4271
src/tests/containerizer/volume_image_isolator_tests.cpp f14a0bd1c44c069c2784638132a08072a2343309
src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp f873e288f72dbecc33b9c1c817688332c0eb3d31
src/tests/default_executor_tests.cpp e5a337436dfac2f099d047b350dd66f295430d34
src/tests/master_validation_tests.cpp 42f566b66e1f03fa3473c9dbfe65c7cd5b27c6cc
src/tests/mesos.hpp f94882f44e7fd35f6e9aaa381656af5c5a58ff9e
src/tests/slave_authorization_tests.cpp 54b5d3692b5d4aa08b2c394bcdfd90f1428dc855
src/tests/teardown_tests.cpp 30c99f9da8be8ec29d8ba3c278c8477c4ed41b2f
Diff: https://reviews.apache.org/r/54554/diff/
Testing
-------
`make check` (OS X, clang w/ libc++, various Linux setups in internal CI)
Thanks,
Benjamin Bannier
Re: Review Request 54554: Do not assume std symbols are visible
without using FQN.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54554/#review158678
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Dec. 8, 2016, 11:05 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54554/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 11:05 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Some headers in libprocess contain using decls for names from the
> standard namespace. This commit is a cleanup to allow us to remove
> these globally visible using decls in a later commit.
>
> In this commit we also add missing std includes for the touched
> symbols.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/gpu/isolator.hpp cd79033b24cd54e1b7e1c18beeb1629fc0f18537
> src/tests/api_tests.cpp 4bc2c746162b937cc1bdb886963b7835bf581c61
> src/tests/command_executor_tests.cpp 63527863d3667bfd501b6da25e49bb22a65f9be0
> src/tests/containerizer/appc_spec_tests.cpp f8fef884febb518249f94a395d4413bfc6be3e12
> src/tests/containerizer/docker_tests.cpp 2f4e84ac10a00d59aa0b979055d5669ced4c895e
> src/tests/containerizer/io_switchboard_tests.cpp 43f1ad6c13d25dca1e316ea9e622566a2af1c45d
> src/tests/containerizer/nested_mesos_containerizer_tests.cpp 7744c83062cf30e515dd0a220c6080d63ba8c14d
> src/tests/containerizer/nvidia_gpu_isolator_tests.cpp 74e06f0d588abc7423534a1e2a4050922cef4271
> src/tests/containerizer/volume_image_isolator_tests.cpp f14a0bd1c44c069c2784638132a08072a2343309
> src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp f873e288f72dbecc33b9c1c817688332c0eb3d31
> src/tests/default_executor_tests.cpp e5a337436dfac2f099d047b350dd66f295430d34
> src/tests/master_validation_tests.cpp 42f566b66e1f03fa3473c9dbfe65c7cd5b27c6cc
> src/tests/mesos.hpp f94882f44e7fd35f6e9aaa381656af5c5a58ff9e
> src/tests/slave_authorization_tests.cpp 54b5d3692b5d4aa08b2c394bcdfd90f1428dc855
> src/tests/teardown_tests.cpp 30c99f9da8be8ec29d8ba3c278c8477c4ed41b2f
>
> Diff: https://reviews.apache.org/r/54554/diff/
>
>
> Testing
> -------
>
> `make check` (OS X, clang w/ libc++, various Linux setups in internal CI)
>
>
> Thanks,
>
> Benjamin Bannier
>
>