You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/09/28 10:29:00 UTC

[jira] [Commented] (NUTCH-3007) Fix impossible casts

    [ https://issues.apache.org/jira/browse/NUTCH-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769982#comment-17769982 ] 

ASF GitHub Bot commented on NUTCH-3007:
---------------------------------------

sebastian-nagel opened a new pull request, #781:
URL: https://github.com/apache/nutch/pull/781

   - remove code blocks (else clauses) unneeded and containing impossible casts




> Fix impossible casts
> --------------------
>
>                 Key: NUTCH-3007
>                 URL: https://issues.apache.org/jira/browse/NUTCH-3007
>             Project: Nutch
>          Issue Type: Sub-task
>    Affects Versions: 1.19
>            Reporter: Sebastian Nagel
>            Assignee: Sebastian Nagel
>            Priority: Major
>             Fix For: 1.20
>
>
> Spotbugs reports two occurrences of
>   Impossible cast from java.util.ArrayList to String[] in org.apache.nutch.fetcher.Fetcher.run(Map, String)
> Both were introduced later into the {{run(Map<String, Object> args, String crawlId)}} method and obviously never used (would throw a ClassCastException). The code blocks should be removed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)