[GitHub] [hive] marton-bod commented on a change in pull request #3131: HIVE-26102: Implement DELETE statements for Iceberg tables

[GitBox <gi...@apache.org>]

marton-bod commented on a change in pull request #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r840409327



##########
File path: iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -261,6 +268,13 @@ public boolean nextKeyValue() throws IOException {
       while (true) {
         if (currentIterator.hasNext()) {
           current = currentIterator.next();
+          Configuration conf = context.getConfiguration();
+          if (HiveIcebergStorageHandler.isDelete(conf, conf.get(Catalogs.NAME))) {
+            if (current instanceof GenericRecord) {
+              PositionDeleteInfo pdi = IcebergAcidUtil.parsePositionDeleteInfoFromRecord((GenericRecord) current);
+              PositionDeleteInfo.serializeIntoConf(conf, pdi);

Review comment:
       Mostly because the row_position changes for every record. If the record reader has multiple tasks (i.e. reading multiple files), then the file_path or even the spec_id/partition_struct could change too




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org