You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Patrick Mayweg <ma...@qint.de> on 2004/03/16 16:01:27 UTC
[PATCH] Building python swig bindings on Win32
Hi,
the python swig bindings cannot be compiled on trunk,branches/1.0.x and
the 1.0.1 tarball. The reason is the use of the non standarized type
"long long" in the file "subversion/bindings/swig/svn_types.i". It
should be replaced by apr_int64_t. The other swig based bindings may
also have the same problem.
[[
* subversion/bindings/swig/svn_types.i
Exchange the non standard type "long long" with the apr type
apr_int64_t.
]]
Index: subversion/bindings/swig/svn_types.i
===================================================================
--- subversion/bindings/swig/svn_types.i (revision 9065)
+++ subversion/bindings/swig/svn_types.i (working copy)
@@ -183,7 +183,7 @@
%typemap(python,argout,fragment="t_output_helper") svn_filesize_t *
"$result = t_output_helper($result,
- PyLong_FromLongLong((long long) (*$1)));";
+ PyLong_FromLongLong((apr_int64_t) (*$1)));";
/* XXX: apply long long *OUTPUT doesn't track $1 correctly */
%typemap(perl5,argout) svn_filesize_t * {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Building python swig bindings on Win32
Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Tuesday, March 16, 2004 5:01 PM +0100 Patrick Mayweg <ma...@qint.de>
wrote:
> Hi,
> the python swig bindings cannot be compiled on trunk,branches/1.0.x and the
> 1.0.1 tarball. The reason is the use of the non standarized type "long long"
> in the file "subversion/bindings/swig/svn_types.i". It should be replaced by
> apr_int64_t. The other swig based bindings may also have the same problem.
Looks fine to me.
Please commit to the trunk (cite me as Approved or whatnot). -- justin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Building python swig bindings on Win32
Posted by Ben Reser <be...@reser.org>.
On Tue, Mar 16, 2004 at 05:01:27PM +0100, Patrick Mayweg wrote:
> Hi,
> the python swig bindings cannot be compiled on trunk,branches/1.0.x and
> the 1.0.1 tarball. The reason is the use of the non standarized type
> "long long" in the file "subversion/bindings/swig/svn_types.i". It
> should be replaced by apr_int64_t. The other swig based bindings may
> also have the same problem.
>
> [[
> * subversion/bindings/swig/svn_types.i
> Exchange the non standard type "long long" with the apr type
> apr_int64_t.
> ]]
>
> Index: subversion/bindings/swig/svn_types.i
> ===================================================================
> --- subversion/bindings/swig/svn_types.i (revision 9065)
> +++ subversion/bindings/swig/svn_types.i (working copy)
> @@ -183,7 +183,7 @@
>
> %typemap(python,argout,fragment="t_output_helper") svn_filesize_t *
> "$result = t_output_helper($result,
> - PyLong_FromLongLong((long long) (*$1)));";
> + PyLong_FromLongLong((apr_int64_t) (*$1)));";
>
> /* XXX: apply long long *OUTPUT doesn't track $1 correctly */
> %typemap(perl5,argout) svn_filesize_t * {
Ignore my previous email. Yeah SWIG won't handle this for us. This
patch is fine. If you don't commit it before me I'll get to it here in
a bit.
--
Ben Reser <be...@reser.org>
http://ben.reser.org
"Conscience is the inner voice which warns us somebody may be looking."
- H.L. Mencken
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org