[GitHub] [phoenix] tkhurana commented on a change in pull request #723: PHOENIX-5757 IndexUpgrade tool set Phoenix query and Hbase rpc timeouts

[GitBox <gi...@apache.org>]

tkhurana commented on a change in pull request #723: PHOENIX-5757 IndexUpgrade tool set Phoenix query and Hbase rpc timeouts
URL: https://github.com/apache/phoenix/pull/723#discussion_r388493365
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexUpgradeTool.java
 ##########
 @@ -314,12 +316,39 @@ public void prepareToolSetup() {
         }
     }
 
+    private static void setRpcRetriesAndTimeouts(Configuration conf) {
+        long indexRebuildQueryTimeoutMs =
+                conf.getLong(QueryServices.INDEX_REBUILD_QUERY_TIMEOUT_ATTRIB,
 
 Review comment:
   INDEX_REBUILD_* config values are phoenix configuration values which are different from the corresponding hbase corresponding values. For example there is a `hbase.client.scanner.timeout.period` defined as 1 minute in our environment but this change is using the value of `phoenix.index.rebuild.client.scanner.timeout` to set the corresponding hbase scan timeout. I don't see these values being defined so they will fallback to their defaults. At the same time it gives us flexibility to tune these values via config overrides. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services