[GitHub] [skywalking] wu-sheng commented on a change in pull request #7509: Support grouped dynamic configurations in DCS and add zookeeper implementation

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #7509:
URL: https://github.com/apache/skywalking/pull/7509#discussion_r692721562



##########
File path: oap-server/server-configuration/configuration-api/src/main/java/org/apache/skywalking/oap/server/configuration/api/ConfigChangeWatcher.java
##########
@@ -60,14 +62,25 @@ public String toString() {
     public static class ConfigChangeEvent {
         private String newValue;
         private EventType eventType;
+        private String groupItemName;
 
         public ConfigChangeEvent(String newValue, EventType eventType) {
             this.newValue = newValue;
             this.eventType = eventType;
         }
+
+        public ConfigChangeEvent(String groupItemName, String newValue, EventType eventType) {
+            this.groupItemName = groupItemName;
+            this.newValue = newValue;
+            this.eventType = eventType;
+        }
     }
 
     public enum EventType {
         ADD, MODIFY, DELETE
     }
+
+    public enum WatchType {
+        SIMPLE, GROUP

Review comment:
       ```suggestion
           SINGLE, GROUP
   ```
   
   I think SINGLE is a better word?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org