You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2025/03/24 03:28:04 UTC

[PR] [MINOR][SQL][DOCS] Improve the SQL example for join strategy [spark]

beliefer opened a new pull request, #50359:
URL: https://github.com/apache/spark/pull/50359

   ### What changes were proposed in this pull request?
   This PR proposes to improve the SQL example for join strategy.
   
   ### Why are the changes needed?
   The SQL example for join strategy confuses users as if the join strategy is related to the join order. This PR makes consistent join order for all the examples.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   Just docs.
   
   
   ### How was this patch tested?
   No need.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [MINOR][SQL][DOCS] Improve the SQL example for join strategy [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #50359:
URL: https://github.com/apache/spark/pull/50359#issuecomment-2746978883

   @LuciferYang @HyukjinKwon Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [MINOR][SQL][DOCS] Improve the SQL example for join strategy [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #50359:
URL: https://github.com/apache/spark/pull/50359#issuecomment-2746965106

   Merged into master for Apache Spark 4.1.0. Thanks @beliefer and @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [MINOR][SQL][DOCS] Improve the SQL example for join strategy [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #50359:
URL: https://github.com/apache/spark/pull/50359#issuecomment-2746905984

   ping @dongjoon-hyun @HyukjinKwon @LuciferYang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [MINOR][SQL][DOCS] Improve the SQL example for join strategy [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #50359: [MINOR][SQL][DOCS] Improve the SQL example for join strategy
URL: https://github.com/apache/spark/pull/50359


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org