[GitHub] [ozone] siddhantsangwan commented on a diff in pull request #4118: HDDS-7666. EC: Unrecoverable EC containers with some remaining replicas may block decommissioning

[GitBox <gi...@apache.org>]

siddhantsangwan commented on code in PR #4118:
URL: https://github.com/apache/ozone/pull/4118#discussion_r1061396577


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/health/ECReplicationCheckHandler.java:
##########
@@ -149,10 +151,16 @@ public ContainerHealthResult checkHealth(ContainerCheckRequest request) {
         dueToDecommission = false;
         remainingRedundancy = repConfig.getParity() - missingIndexes.size();
       }
-      return new ContainerHealthResult.UnderReplicatedHealthResult(
-          container, remainingRedundancy, dueToDecommission,
-          replicaCount.isSufficientlyReplicated(true),
-          replicaCount.isUnrecoverable());
+      ContainerHealthResult.UnderReplicatedHealthResult result =
+          new ContainerHealthResult.UnderReplicatedHealthResult(
+              container, remainingRedundancy, dueToDecommission,
+              replicaCount.isSufficientlyReplicated(true),
+              replicaCount.isUnrecoverable());
+      if (replicaCount.decommissioningOnlyIndexes(true).size() > 0

Review Comment:
   These methods will also count indexes that are on `DECOMMISSIONED` or `IN_MAINTENANCE` datanodes. I guess we only want to add datanodes that haven't yet entered these states to the under rep queue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org