You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/21 03:37:32 UTC
[GitHub] [spark] wankunde opened a new pull request, #37594: [SPARK-40159][SQL] Aggregate should be group only after collapse project to aggregate
wankunde opened a new pull request, #37594:
URL: https://github.com/apache/spark/pull/37594
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
Aggregate should be group only if there not exists AggregateFunction in aggregate.groupingExpressions
### Why are the changes needed?
CollapseProject rule will merge project expressions into AggregateExpressions in aggregate, which will make the aggregate.groupOnly to false.
For example:
```java
val df = testData.distinct().select('key + 1, ('key + 1).cast("long"))
df.queryExecution.optimizedPlan.collect {
case a: Aggregate => a
}.foreach(agg => assert(agg.groupOnly === true))
```
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #37594: [SPARK-40159][SQL] Aggregate should be group only after collapse project to aggregate
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #37594:
URL: https://github.com/apache/spark/pull/37594#issuecomment-1221462886
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wankunde commented on pull request #37594: [SPARK-40159][SQL] Aggregate should be group only after collapse project to aggregate
Posted by GitBox <gi...@apache.org>.
wankunde commented on PR #37594:
URL: https://github.com/apache/spark/pull/37594#issuecomment-1225429044
Bad case :
```
explain cost select cast(id as smallint) from ( select distinct id from range(10)) t;
+----------------------------------------------------+
| plan |
+----------------------------------------------------+
| == Optimized Logical Plan ==
Aggregate [id#760L], [cast(id#760L as smallint) AS id#761], Statistics(sizeInBytes=50.0 B)
+- Range (0, 10, step=1, splits=None), Statistics(sizeInBytes=80.0 B)
== Physical Plan ==
AdaptiveSparkPlan isFinalPlan=false
+- HashAggregate(keys=[id#760L], functions=[], output=[id#761]), OptimizeTags: [created by RemoveRedundantPartialAggregates]
+- Range (0, 10, step=1, splits=300)
```
Close this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wankunde closed pull request #37594: [SPARK-40159][SQL] Aggregate should be group only after collapse project to aggregate
Posted by GitBox <gi...@apache.org>.
wankunde closed pull request #37594: [SPARK-40159][SQL] Aggregate should be group only after collapse project to aggregate
URL: https://github.com/apache/spark/pull/37594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org