You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/03 08:09:37 UTC

[GitHub] [skywalking-java] JoeKerouac commented on pull request #267: fix bug

JoeKerouac commented on PR #267:
URL: https://github.com/apache/skywalking-java/pull/267#issuecomment-1173034764

   @wu-sheng when you import apm-spring-cloud-gateway-2.1.x-plugin or apm-spring-cloud-gateway-3.x-plugin, and import spring-cloud-gateway, spring-cloud-gateway-x.x.x-plugin will work, and LocalSpan will be created in `org.apache.skywalking.apm.plugin.spring.cloud.gateway.v3x.NettyRoutingFilterInterceptor#beforeMethod` (or `org.apache.skywalking.apm.plugin.spring.cloud.gateway.v21x.NettyRoutingFilterInterceptor#beforeMethod`), but not release it in `org.apache.skywalking.apm.plugin.spring.cloud.gateway.v3x.NettyRoutingFilterInterceptor#afterMethod` (or `org.apache.skywalking.apm.plugin.spring.cloud.gateway.v21x.NettyRoutingFilterInterceptor#afterMethod`);
   
   **This will cause memory leak**;


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org