[GitHub] [accumulo] jmark99 opened a new pull request, #3193: Update validation of options in Sampler code

["jmark99 (via GitHub)" <gi...@apache.org>]

jmark99 opened a new pull request, #3193:
URL: https://github.com/apache/accumulo/pull/3193

   Discovered a bug in AbstractHashSampler and RowColumnSampler classes while examining the Sample example. The final portion of the example was failing to return any data. Found that the AbstractHashSampler would produce and error any time an any additional option were provided. It would only handle the required hasher and modulus options correctly.
   
   Conversely, the RowColumnSampler would fail when presented with the require hasher and modulus options.
   
   Updated such that the RowColumnSampler will ignore the required options, allowing the AbstractHashSampler to handle them, and only validate options specific to the RowColumnSampler.
   
   The AbstractHashSampler was updated to ignore any non-required options.
   
   Added comments to indicate that the AbstractHashSampler validates required options while calling sub-classes should handle any additional Sampler specific options.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] jmark99 merged pull request #3193: Update validation of options in Sampler code

["jmark99 (via GitHub)" <gi...@apache.org>]

jmark99 merged PR #3193:
URL: https://github.com/apache/accumulo/pull/3193


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org