You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/02/11 22:35:08 UTC

[GitHub] [echarts] thesiti92 opened a new pull request #14263: Add LegendComponentOption.icon property type

thesiti92 opened a new pull request #14263:
URL: https://github.com/apache/echarts/pull/14263


   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ X ] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   adds the icon property to LegendComponentOption
   
   
   ### Fixed issues
   
   https://github.com/apache/echarts/issues/14262
   
   
   ## Details
   
   ### Before: What was the problem?
   
   couldnt add a strongly typed legend option object because the icon property didnt exist
   
   
   ### After: How is it fixed in this PR?
   
   add the type for it
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   Updates the TS types to be in line with the echarts docs https://echarts.apache.org/en/option.html#legend.icon 
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14263: Add LegendComponentOption.icon property type

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14263:
URL: https://github.com/apache/echarts/pull/14263#issuecomment-780238999


   Congratulations! Your PR has been merged. Thanks for your contribution! 👍


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] pissang merged pull request #14263: Add LegendComponentOption.icon property type

Posted by GitBox <gi...@apache.org>.
pissang merged pull request #14263:
URL: https://github.com/apache/echarts/pull/14263


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #14263: Add LegendComponentOption.icon property type

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #14263:
URL: https://github.com/apache/echarts/pull/14263#issuecomment-777837991


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org