[GitHub] [cassandra] adelapena commented on a diff in pull request #2436: CASSANDRA-18613 trunk: Add support for vectors on UDFs

["adelapena (via GitHub)" <gi...@apache.org>]

adelapena commented on code in PR #2436:
URL: https://github.com/apache/cassandra/pull/2436#discussion_r1241975561


##########
src/java/org/apache/cassandra/cql3/functions/types/CodecRegistry.java:
##########
@@ -847,6 +864,12 @@ private <T> TypeCodec<T> maybeCreateCodec(DataType cqlType, T value)
             }
         }
 
+        if ((cqlType == null || cqlType.getName() == VECTOR) && value instanceof List)

Review Comment:
   Here `VECTOR` follows the style of the previous checks for `LIST`, `SET` and `MAP`. The differences start on the checks for `TUPLE` and `UDT`. I have changed the previous code to use the static import in all cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org