You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/12/11 13:37:00 UTC

[jira] [Commented] (AIRFLOW-3500) Make task duration display user friendly

    [ https://issues.apache.org/jira/browse/AIRFLOW-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717162#comment-16717162 ] 

ASF GitHub Bot commented on AIRFLOW-3500:
-----------------------------------------

oferze opened a new pull request #4304: [AIRFLOW-3500] Make task duration display user friendly
URL: https://github.com/apache/incubator-airflow/pull/4304
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW-3500) issue and references it in the PR title.
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   Duration (when hovering over a task in Graph mode) will now be displayed in a human-friendly way, such as:
   
   ![image](https://user-images.githubusercontent.com/5157769/49803972-80f87d80-fda5-11e8-84a7-338298008ca1.png)
   
   ### Tests
   
   - [X] My PR does not need testing for this extremely good reason: JS display change
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [X] ~Passes `flake8`~ N/A - JS change only
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Make task duration display user friendly
> ----------------------------------------
>
>                 Key: AIRFLOW-3500
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3500
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: DAG
>    Affects Versions: 1.10.1
>            Reporter: Ofer Zelig
>            Assignee: Ofer Zelig
>            Priority: Major
>             Fix For: 1.10.2
>
>
> When hovering over a task (in Graph mode), the duration it took is displayed as a plain number, which doesn't say what the number is (it's actually seconds).
> When you see something like 2716 it's impractical to know how much time it actually took, unless you can quickly do the math in your head.
> Change the display to read days/hours/minutes/seconds.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)