You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/08/26 13:57:15 UTC
[PR] HDDS-11365. Fix the NOTICE file [ozone]
adoroszlai opened a new pull request, #7120:
URL: https://github.com/apache/ozone/pull/7120
## What changes were proposed in this pull request?
Include Ozone's NOTICE.txt in jars instead of the one from Hadoop. This is achieved by creating a helper module to bundle the LICENSE.txt and NOTICE.txt files, and using it in all other modules.
Also, bump year to current in NOTICE.txt
https://issues.apache.org/jira/browse/HDDS-11365
## How was this patch tested?
```
$ for f in hadoop-ozone/dist/target/ozone-1.5.0-SNAPSHOT/share/ozone/lib/{hdds,ozone}*jar; do
unzip -p "$f" META-INF/NOTICE.txt | head -2
done | sort -u
Apache Ozone
Copyright 2024 The Apache Software Foundation
```
CI:
https://github.com/adoroszlai/ozone/actions/runs/10560183800
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11365. Fix the NOTICE file [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #7120:
URL: https://github.com/apache/ozone/pull/7120#issuecomment-2310966354
Is there any way we can automatically update the year in the notice file? We can also add a step to the release manager guide to bump the year if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11365. Fix the NOTICE file [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7120:
URL: https://github.com/apache/ozone/pull/7120#issuecomment-2312788674
Thanks @ayushtkn, @ChenSammi, @errose28 for the review, also @ayushtkn for reporting the problem.
I don't think we can automatically bump the year, since we need the NOTICE file in the source release. We could add a workflow to open a PR on 1st January each year, but seems to be overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11365. Fix the NOTICE file [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on PR #7120:
URL: https://github.com/apache/ozone/pull/7120#issuecomment-2312793292
Agreed workflow seems like overkill. I'll add this step when I update the release manager guide after 1.4.1 goes out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11365. Fix the NOTICE file [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7120:
URL: https://github.com/apache/ozone/pull/7120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11365. Fix the NOTICE file [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #7120:
URL: https://github.com/apache/ozone/pull/7120#issuecomment-2311966688
Thanks @adoroszlai for correcting the NOTICE file. If it's not easy to update the year in NOTICE file automatically, let's add the year check in NOTICE file as one step in release guideline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org