You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "aofall (via GitHub)" <gi...@apache.org> on 2024/04/29 09:25:39 UTC
[PR] update: compatible dubbo 3.0.x [dubbo-spi-extensions]
aofall opened a new pull request, #336:
URL: https://github.com/apache/dubbo-spi-extensions/pull/336
## What is the purpose of the change
1. Use `rivision` tag manager version and Bump version to 3.0.0-SNAPSHOT
2. Cherry pick bug fix from master branch
3. fix test case failed
## Brief changelog
compatible dubbo 3.0.x
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit
in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
exist. If the new feature or significant change is committed, please remember to add sample
in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure
unit-test and integration-test pass.
- [ ] If this contribution is large, please follow
the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] update: compatible dubbo 3.0.x [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng merged PR #336:
URL: https://github.com/apache/dubbo-spi-extensions/pull/336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] update: compatible dubbo 3.0.x [dubbo-spi-extensions]
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #336:
URL: https://github.com/apache/dubbo-spi-extensions/pull/336#issuecomment-2099583028
@songxiaosheng PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] update: compatible dubbo 3.0.x [dubbo-spi-extensions]
Posted by "aofall (via GitHub)" <gi...@apache.org>.
aofall commented on PR #336:
URL: https://github.com/apache/dubbo-spi-extensions/pull/336#issuecomment-2100191745
@AlbumenJ Could you please retrigger the workflow of [Build and Test For PR / Unit Test ubuntu-latest with JDK 8](https://github.com/apache/dubbo-spi-extensions/actions/runs/8876307818/job/24367913394?pr=336)
It works fine on my own repository. https://github.com/aofall/dubbo-spi-extensions/actions/runs/8875523206
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] update: compatible dubbo 3.0.x [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on PR #336:
URL: https://github.com/apache/dubbo-spi-extensions/pull/336#issuecomment-2100401852
please fix ci problem
```
606Z [INFO] Running org.apache.dubbo.rpc.cluster.loadbalance.PeakEwmaLoadBalanceTest
2024-04-29T09:36:22.7778212Z [ERROR] Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.691 s <<< FAILURE! - in org.apache.dubbo.rpc.cluster.loadbalance.PeakEwmaLoadBalanceTest
2024-04-29T09:36:22.7788736Z [ERROR] testWithShake Time elapsed: 2.337 s <<< FAILURE!
2024-04-29T09:36:22.7800022Z org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
2024-04-29T09:36:22.7806357Z at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
2024-04-29T09:36:22.7812762Z at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
2024-04-29T09:36:22.7818645Z at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
2024-04-29T09:36:22.7824182Z at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
2024-04-29T09:36:22.7829759Z at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
2024-04-29T09:36:22.7836287Z at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:180)
2024-04-29T09:36:22.7850320Z at org.apache.dubbo.rpc.cluster.loadbalance.PeakEwmaLoadBalanceTest.testWithShake(PeakEwmaLoadBalanceTest.java:76)
2024-04-29T09:36:22.7862261Z at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
2024-04-29T09:36:22.7867960Z at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
2024-04-29T09:36:22.7876823Z at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
2024-04-29T09:36:22.7880811Z at java.lang.reflect.Method.invoke(Method.java:498)
2024-04-29T09:36:22.7887588Z at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:727)
2024-04-29T09:36:22.7889466Z at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
2024-04-29T09:36:22.7895040Z at
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] update: compatible dubbo 3.0.x [dubbo-spi-extensions]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #336:
URL: https://github.com/apache/dubbo-spi-extensions/pull/336#issuecomment-2082291298
## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/336?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `1 lines` in your changes are missing coverage. Please review.
> Project coverage is 31.30%. Comparing base [(`2752e83`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/2752e830e55fdf9e9d7aa140e90db05f3e386b9b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c895ca4`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/336?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/336?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...apache/dubbo/rpc/rocketmq/codec/RocketMQCodec.java](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/336?src=pr&el=tree&filepath=dubbo-rpc-extensions%2Fdubbo-rpc-rocketmq%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdubbo%2Frpc%2Frocketmq%2Fcodec%2FRocketMQCodec.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHViYm8tcnBjLWV4dGVuc2lvbnMvZHViYm8tcnBjLXJvY2tldG1xL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvcm9ja2V0bXEvY29kZWMvUm9ja2V0TVFDb2RlYy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.0.0 #336 +/- ##
============================================
- Coverage 34.04% 31.30% -2.74%
+ Complexity 506 459 -47
============================================
Files 156 149 -7
Lines 5326 5201 -125
Branches 662 654 -8
============================================
- Hits 1813 1628 -185
- Misses 3314 3398 +84
+ Partials 199 175 -24
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/336?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org