[GitHub] [kafka] wcarlson5 commented on a diff in pull request #12549: KAFKA-10199: Introduce task registry

[GitBox <gi...@apache.org>]

wcarlson5 commented on code in PR #12549:
URL: https://github.com/apache/kafka/pull/12549#discussion_r952998259


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -1575,7 +1576,7 @@ void addTask(final Task task) {
         tasks.addTask(task);
     }
 
-    Tasks tasks() {
+    TasksRegistry tasks() {

Review Comment:
   nit: Maybe we want to update the name along with the type?



##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -540,7 +542,7 @@ public void shouldHandleRemovedTasksFromStateUpdater() {
             "taskManagerTest",
             activeTaskCreator,
             standbyTaskCreator,
-            topologyMetadata,
+            new Tasks(new LogContext()), topologyMetadata,

Review Comment:
   nit: new line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org