You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/02/17 23:20:12 UTC
[commons-rng] 01/03: Update checkstyle
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-rng.git
commit d75911b3d9d598244b974bbe52b9bb9114739ef2
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Mon Feb 17 23:10:35 2020 +0000
Update checkstyle
maven plugin 3.0.0 -> 3.1.0
Dependency 8.20 -> 8.29
---
pom.xml | 4 ++--
src/main/resources/checkstyle/checkstyle.xml | 21 +++++++++------------
2 files changed, 11 insertions(+), 14 deletions(-)
diff --git a/pom.xml b/pom.xml
index a7e7a53..e022b88 100644
--- a/pom.xml
+++ b/pom.xml
@@ -56,8 +56,8 @@
<maven.compiler.target>1.6</maven.compiler.target>
<rng.pmd.version>3.12.0</rng.pmd.version>
<rng.pmd.dep.version>6.14.0</rng.pmd.dep.version>
- <rng.checkstyle.version>3.0.0</rng.checkstyle.version>
- <rng.checkstyle.dep.version>8.20</rng.checkstyle.dep.version>
+ <rng.checkstyle.version>3.1.0</rng.checkstyle.version>
+ <rng.checkstyle.dep.version>8.29</rng.checkstyle.dep.version>
<rng.mathjax.url>https://cdn.jsdelivr.net/npm/mathjax@3/es5/tex-mml-chtml.js</rng.mathjax.url>
<rng.antrun.version>1.8</rng.antrun.version>
<!-- Workaround to avoid duplicating config files. -->
diff --git a/src/main/resources/checkstyle/checkstyle.xml b/src/main/resources/checkstyle/checkstyle.xml
index 68f301e..4c71c7f 100644
--- a/src/main/resources/checkstyle/checkstyle.xml
+++ b/src/main/resources/checkstyle/checkstyle.xml
@@ -21,7 +21,7 @@
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
"https://checkstyle.org/dtds/configuration_1_3.dtd">
-<!--
+<!--
Commons RNG customization of default Checkstyle behaviour:
https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/sun_checks.xml
-->
@@ -57,6 +57,12 @@
<!-- Checks for Size Violations. -->
<!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
<module name="FileLength" />
+ <module name="LineLength">
+ <property name="fileExtensions" value="java"/>
+ <!-- Ignore lines that begin with " * ", such as within a Javadoc comment. -->
+ <property name="ignorePattern" value="^ *\* *[^ ]"/>
+ <property name="max" value="120"/>
+ </module>
<!-- Checks for whitespace -->
<!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
@@ -81,12 +87,8 @@
<!-- Checks for Javadoc comments. -->
<!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
- <!-- Require method javadocs, allow undeclared RTE -->
- <module name="JavadocMethod">
- <property name="allowUndeclaredRTE" value="true"/>
- <property name="allowThrowsTagsForSubclasses" value="true"/>
- <property name="validateThrows" value="false"/>
- </module>
+ <module name="InvalidJavadocPosition"/>
+ <module name="JavadocMethod" />
<module name="JavadocType" />
<module name="JavadocVariable" />
<module name="JavadocStyle" />
@@ -115,11 +117,6 @@
<!-- Checks for Size Violations. -->
<!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
- <module name="LineLength">
- <!-- Ignore lines that begin with " * ", such as within a Javadoc comment. -->
- <property name="ignorePattern" value="^ *\* *[^ ]"/>
- <property name="max" value="120"/>
- </module>
<module name="MethodLength" />
<module name="ParameterNumber" />