You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/03/17 09:50:43 UTC
[GitHub] [camel-k] tplevko opened a new pull request #2142: Add toleration trait e2e test
tplevko opened a new pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142
<!-- Description -->
xref: https://issues.redhat.com/browse/ENTESB-15832
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
e2e test coverage for toleration trait
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2142: Add toleration trait e2e test
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142#issuecomment-801293399
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2142: Add toleration trait e2e test
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142#issuecomment-800962100
I created https://github.com/apache/camel-k/pull/2123/files#diff-c5088002fef267f74c89b31c5472e9782c2cca9dc3e2e1b354c85d9553b1a042 few days ago.
I've tried to cover a real use, rather than _artificial_ ones, that are already covered by unit tests. However this proves bit challenging as this requires a mutli-nodes cluster. I'm happy to drop my changes in favour of this version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2142: Add toleration trait e2e test
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142#issuecomment-801250736
@tplevko that's a good idea 👍🏼. We can merge your PR since it's ready, and I'll merge mine into it. Does that work for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tplevko commented on pull request #2142: Add toleration trait e2e test
Posted by GitBox <gi...@apache.org>.
tplevko commented on pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142#issuecomment-801065369
@astefanutti also there is also one more option - I can add these tests to the one you added. To increase the coverage. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #2142: Add toleration trait e2e test
Posted by GitBox <gi...@apache.org>.
astefanutti commented on pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142#issuecomment-801293204
@tplevko thanks. Let me merge it. Yaks tests errors are unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tplevko commented on pull request #2142: Add toleration trait e2e test
Posted by GitBox <gi...@apache.org>.
tplevko commented on pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142#issuecomment-801278516
@astefanutti sounds good to me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti merged pull request #2142: Add toleration trait e2e test
Posted by GitBox <gi...@apache.org>.
astefanutti merged pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tplevko commented on pull request #2142: Add toleration trait e2e test
Posted by GitBox <gi...@apache.org>.
tplevko commented on pull request #2142:
URL: https://github.com/apache/camel-k/pull/2142#issuecomment-801011126
@astefanutti I agree that this version might feel a bit artificial and the test you provided corresponds more with the e2e testsuite objective. I think it will be better to go with your changes and we can close this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org