Re: [PR] HDDS-15026. Introduce DevContainer to improve contributor experience [ozone]

["henrybear327 (via GitHub)" <gi...@apache.org>]

henrybear327 commented on code in PR #10075:
URL: https://github.com/apache/ozone/pull/10075#discussion_r3175309513


##########
.devcontainer/devcontainer.json:
##########
@@ -0,0 +1,29 @@
+{
+  "name": "Apache Ozone (Java 21)",
+  "image": "mcr.microsoft.com/devcontainers/java:21-bookworm",
+  "features": {
+    "ghcr.io/devcontainers/features/java:1": {
+      "version": "none",
+      "installMaven": "true"
+    },
+    "ghcr.io/devcontainers/features/node:1": {
+      "version": "20"
+    },
+		"ghcr.io/devcontainers/features/docker-in-docker:2": {},
+		"ghcr.io/devcontainers/features/github-cli:1": {},
+  },
+  "postCreateCommand": "hadoop-ozone/dev-support/checks/build.sh -Pdist -Psrc -Dmaven.javadoc.skip=true",

Review Comment:
   This discussion https://github.com/orgs/devcontainers/discussions/5 has a good answer. 
   
   TL;DR the compilation steps for the ozone should happen here, and it will happen after the container is created (meaning that you can see a working VScode web launched successfully), and you can already start working on the code, just that in the background, you can see the compilation of ozone is happening (for ~10 minutes IIRC)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org