You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/02/11 04:36:39 UTC
[kudu-CR] csd: remove from repo
Hello Jean-Daniel Cryans, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5973
to review the following change.
Change subject: csd: remove from repo
......................................................................
csd: remove from repo
It never really made sense for the CSD to exist in Kudu's repo, as it is
tightly coupled to Cloudera Manager. After ensuring that it'll live on in a
separate Cloudera repository, this commit removes it.
I searched for CSD-related references using 'git grep -i csd'.
Change-Id: I8cffc1e536e92adc45a12354c9aacb8046739fb7
---
M RELEASING.adoc
M build-support/jenkins/build-and-test.sh
M build-support/release/rat_exclude_files.txt
M java/README.md
D java/kudu-csd/check_csd_compatibility.py
D java/kudu-csd/generate_mdl.py
D java/kudu-csd/old-version-metrics/0.10.0-master.json
D java/kudu-csd/old-version-metrics/0.10.0-tserver.json
D java/kudu-csd/old-version-metrics/0.9.1-master.json
D java/kudu-csd/old-version-metrics/0.9.1-tserver.json
D java/kudu-csd/old-version-metrics/1.0.0-master.json
D java/kudu-csd/old-version-metrics/1.0.0-tserver.json
D java/kudu-csd/old-version-metrics/1.0.1-master.json
D java/kudu-csd/old-version-metrics/1.0.1-tserver.json
D java/kudu-csd/pom.xml
D java/kudu-csd/src/descriptor/service.sdl
D java/kudu-csd/src/images/icon.png
D java/kudu-csd/src/scripts/kudu.sh
M java/pom.xml
19 files changed, 1 insertion(+), 10,343 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/5973/1
--
To view, visit http://gerrit.cloudera.org:8080/5973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8cffc1e536e92adc45a12354c9aacb8046739fb7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] csd: remove from repo
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: csd: remove from repo
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cffc1e536e92adc45a12354c9aacb8046739fb7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] csd: remove from repo
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: csd: remove from repo
......................................................................
csd: remove from repo
It never really made sense for the CSD to exist in Kudu's repo, as it is
tightly coupled to Cloudera Manager. After ensuring that it'll live on in a
separate Cloudera repository, this commit removes it.
I searched for CSD-related references using 'git grep -i csd'.
Change-Id: I8cffc1e536e92adc45a12354c9aacb8046739fb7
Reviewed-on: http://gerrit.cloudera.org:8080/5973
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M RELEASING.adoc
M build-support/jenkins/build-and-test.sh
M build-support/release/rat_exclude_files.txt
M java/README.md
D java/kudu-csd/check_csd_compatibility.py
D java/kudu-csd/generate_mdl.py
D java/kudu-csd/old-version-metrics/0.10.0-master.json
D java/kudu-csd/old-version-metrics/0.10.0-tserver.json
D java/kudu-csd/old-version-metrics/0.9.1-master.json
D java/kudu-csd/old-version-metrics/0.9.1-tserver.json
D java/kudu-csd/old-version-metrics/1.0.0-master.json
D java/kudu-csd/old-version-metrics/1.0.0-tserver.json
D java/kudu-csd/old-version-metrics/1.0.1-master.json
D java/kudu-csd/old-version-metrics/1.0.1-tserver.json
D java/kudu-csd/pom.xml
D java/kudu-csd/src/descriptor/service.sdl
D java/kudu-csd/src/images/icon.png
D java/kudu-csd/src/scripts/kudu.sh
M java/pom.xml
19 files changed, 1 insertion(+), 10,343 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Todd Lipcon: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cffc1e536e92adc45a12354c9aacb8046739fb7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] csd: remove from repo
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: csd: remove from repo
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/5973
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8cffc1e536e92adc45a12354c9aacb8046739fb7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No