You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/07/22 11:48:10 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/614
CLOUDSTACK-8649: Fixed unnecessary double url decoding in registerSSHKeyPair.
The method cmd.getPublicKey() already returns a decoded string. So when we try to decode it again the plus "+" signs are being decoded to white spaces. In a next step the key is cut at the spaces and only the first two parts are being saved in the DB.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8649
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/614.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #614
----
commit 12a3642df683539fddb3f6be4b223b03744696e2
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-07-22T09:39:19Z
CLOUDSTACK-8649: Fixed unnecessary double url decoding in registerSSHKeyPair.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/614#issuecomment-123650029
Hi @borisroman ,
Should this go into 4.5 first? If so, why?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8649: Fixed unnecessary double...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/614
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---