[GitHub] [flink-kubernetes-operator] gaborgsomogyi commented on a diff in pull request #545: [FLINK-31218] Improve health probe to only detect newly unhealthy informers

["gaborgsomogyi (via GitHub)" <gi...@apache.org>]

gaborgsomogyi commented on code in PR #545:
URL: https://github.com/apache/flink-kubernetes-operator/pull/545#discussion_r1152096544


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/health/HealthProbe.java:
##########
@@ -67,6 +75,21 @@ public boolean isHealthy() {
                 return false;
             }
         }
+
         return true;
     }
+
+    private boolean anyInformerBecameUnhealthy(Set<InformerIdentifier> unhealthyInformers) {
+        boolean unhealthy = false;

Review Comment:
   Maybe this?
   ```
           return unhealthyInformers.stream().anyMatch(unhealthyInformer -> !previousInformerHealthSummary
               .getUnhealthyInformers()
               .contains(unhealthyInformer));
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org