You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by bu...@apache.org on 2017/09/20 11:19:17 UTC

[3/3] hbase git commit: HBASE-18833 Ensure precommit personality is up to date on all active branches

HBASE-18833 Ensure precommit personality is up to date on all active branches

Signed-off-by: Mike Drob <md...@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/b5f1850d
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/b5f1850d
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/b5f1850d

Branch: refs/heads/HBASE-18477
Commit: b5f1850d1f0499d8a9140a3f7169ccc61c5cd62e
Parents: 4bd4f41
Author: Sean Busbey <bu...@apache.org>
Authored: Mon Sep 18 08:58:09 2017 -0500
Committer: Sean Busbey <bu...@apache.org>
Committed: Wed Sep 20 06:18:31 2017 -0500

----------------------------------------------------------------------
 dev-support/hbase-personality.sh | 50 ++++++++++++++++++++++++++++++++---
 1 file changed, 46 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/hbase/blob/b5f1850d/dev-support/hbase-personality.sh
----------------------------------------------------------------------
diff --git a/dev-support/hbase-personality.sh b/dev-support/hbase-personality.sh
index 9f591b1..b7a2f97 100755
--- a/dev-support/hbase-personality.sh
+++ b/dev-support/hbase-personality.sh
@@ -119,8 +119,7 @@ function personality_modules
     yetus_debug "EXCLUDE_TESTS_URL = ${EXCLUDE_TESTS_URL}"
     yetus_debug "INCLUDE_TESTS_URL = ${INCLUDE_TESTS_URL}"
     if [[ -n "$EXCLUDE_TESTS_URL" ]]; then
-        wget "$EXCLUDE_TESTS_URL" -O "excludes"
-        if [[ $? -eq 0 ]]; then
+        if wget "$EXCLUDE_TESTS_URL" -O "excludes"; then
           excludes=$(cat excludes)
           yetus_debug "excludes=${excludes}"
           if [[ -n "${excludes}" ]]; then
@@ -132,8 +131,7 @@ function personality_modules
                "${EXCLUDE_TESTS_URL}. Ignoring and proceeding."
         fi
     elif [[ -n "$INCLUDE_TESTS_URL" ]]; then
-        wget "$INCLUDE_TESTS_URL" -O "includes"
-        if [[ $? -eq 0 ]]; then
+        if wget "$INCLUDE_TESTS_URL" -O "includes"; then
           includes=$(cat includes)
           yetus_debug "includes=${includes}"
           if [[ -n "${includes}" ]]; then
@@ -167,6 +165,50 @@ function personality_modules
 
 ###################################################
 
+add_test_type shadedjars
+
+
+function shadedjars_initialize
+{
+  yetus_debug "initializing shaded client checks."
+  maven_add_install shadedjars
+  add_test shadedjars
+}
+
+function shadedjars_clean
+{
+  "${MAVEN}" "${MAVEN_ARGS[@]}" clean -fae -pl hbase_shaded/hbase-shaded-check-invariants -am -Prelease
+}
+
+## @description test the shaded client artifacts
+## @audience private
+## @stability evolving
+## @param repostatus
+function shadedjars_rebuild
+{
+  local repostatus=$1
+  local logfile="${PATCH_DIR}/${repostatus}-shadedjars.txt"
+
+  big_console_header "Checking shaded client builds on ${repostatus}"
+
+  echo_and_redirect "${logfile}" \
+    "${MAVEN}" "${MAVEN_ARGS[@]}" clean verify -fae --batch-mode \
+      -pl hbase-shaded/hbase-shaded-check-invariants -am \
+      -Dtest=NoUnitTests -DHBasePatchProcess -Prelease \
+      -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dfindbugs.skip=true
+
+  count=$(${GREP} -c '\[ERROR\]' "${logfile}")
+  if [[ ${count} -gt 0 ]]; then
+    add_vote_table -1 shadedjars "${repostatus} has ${count} errors when building our shaded downstream artifacts."
+    return 1
+  fi
+
+  add_vote_table +1 shadedjars "${repostatus} has no errors when building our shaded downstream artifacts."
+  return 0
+}
+
+###################################################
+
 add_test_type hadoopcheck
 
 ## @description  hadoopcheck file filter