You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/01/20 13:17:38 UTC

[GitHub] [couchdb] rnewson opened a new pull request #2473: Fix infinite loop in default_authentication_handler

rnewson opened a new pull request #2473: Fix infinite loop in default_authentication_handler
URL: https://github.com/apache/couchdb/pull/2473
 
 
   ## Overview
   
   In #2411 we introduced a setting to allow _up to not require authentication when require_valid_user is set to true. However it was flawed and caused an infinite loop, rendering the /_up handler ineffective.
   
   We move the check to the party_mode_handler and remove the infinite loop.
   
   ## Testing recommendations
   
   dev/run with all combinations of the two config flags, _up handler called with curl to confirm behaviour.
   
   ## Related Issues or Pull Requests
   
   #2411 for original PR that this corrects.
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [x] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [couchdb] rnewson merged pull request #2473: Fix infinite loop in default_authentication_handler

Posted by GitBox <gi...@apache.org>.
rnewson merged pull request #2473: Fix infinite loop in default_authentication_handler
URL: https://github.com/apache/couchdb/pull/2473
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services