[GitHub] [incubator-shardingsphere] wgy8283335 commented on a change in pull request #3543: Add sharding-orchestration-core-new module

[GitBox <gi...@apache.org>]

wgy8283335 commented on a change in pull request #3543: Add sharding-orchestration-core-new module
URL: https://github.com/apache/incubator-shardingsphere/pull/3543#discussion_r347329217
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core-new/src/main/java/org/apache/shardingsphere/orchestration/temp/internal/configcenter/ConfigCenterServiceLoader.java
 ##########
 @@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.orchestration.temp.internal.configcenter;
+
+import com.google.common.base.Preconditions;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.shardingsphere.core.spi.NewInstanceServiceLoader;
+import org.apache.shardingsphere.core.spi.algorithm.TypeBasedSPIServiceLoader;
+import org.apache.shardingsphere.orchestration.center.api.ConfigCenter;
+import org.apache.shardingsphere.orchestration.center.configuration.InstanceConfiguration;
+
+/**
+ * Config center loader from SPI.
+ *
+ * @author wangguangyuan
+ */
+@Slf4j
+public final class ConfigCenterServiceLoader extends TypeBasedSPIServiceLoader<ConfigCenter> {
+    
+    static {
+        NewInstanceServiceLoader.register(ConfigCenter.class);
+    }
+    
+    public ConfigCenterServiceLoader() {
+        super(ConfigCenter.class);
+    }
+    
+    /**
+     * Load config center from SPI.
+     * 
+     * @param configCenterConfig config center configuration
+     * @return config center
+     */
+    public ConfigCenter load(final InstanceConfiguration configCenterConfig) {
 
 Review comment:
   THX. It's a good idea.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services