[GitHub] [ignite] alievmirza commented on a change in pull request #7047: IGNITE-10760 Fix confusing message about system worker blocking

[GitBox <gi...@apache.org>]

alievmirza commented on a change in pull request #7047: IGNITE-10760 Fix confusing message about system worker blocking
URL: https://github.com/apache/ignite/pull/7047#discussion_r345669457
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/worker/WorkersRegistry.java
 ##########
 @@ -225,8 +225,9 @@ public void setSystemWorkerBlockedTimeout(long val) {
 
                         if (worker0 != null && worker0 == worker) {
                             log.error("Blocked system-critical thread has been detected. " +
-                                "This can lead to cluster-wide undefined behaviour " +
-                                "[threadName=" + worker.name() + ", blockedFor=" + heartbeatDelay / 1000 + "s]");
+                                    "This can lead to cluster-wide undefined behaviour " +
+                                    "[workerName=" + worker.name() + ", threadName=" + worker.runner().getName() +
 
 Review comment:
   As far as I can see from the code, the check has already been done at https://github.com/apache/ignite/blob/c1dba9c80cb48ead9a3d6b1e015d54c81503bdec/modules/core/src/main/java/org/apache/ignite/internal/worker/WorkersRegistry.java#L208
   So it seems to me that we don't need to do additional check. 
   
   I can change `worker.runner()` to `runner` to make code cleaner, if it needed. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services