You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/11/07 22:17:35 UTC

[GitHub] [libcloud] Kami commented on pull request #1519: [WIP] Optimize and speed up imports in the EC2 driver and elsewhere

Kami commented on pull request #1519:
URL: https://github.com/apache/libcloud/pull/1519#issuecomment-723502122


   @c-w While analyzing the importd, I noticed the ``requests`` import is quite slow (in the range of 50-100ms).
   
   In most cases, we will indeed want to import requests and perform actual HTTP requests, but in some situations that's not the case and it would be great if we could avoid the important in such scenarios (or at least do it lazily on first request).
   
   https://github.com/apache/libcloud/pull/1332 added a check in ``libcloud/__init__.py`` which means we will always perform that import (even if user will never perform any HTTP requests with Libcloud).
   
   Do you have any idea / suggestion on how we could handle that better? I do think it's good we throw and warn user early in situation such as the one #1332 is supposed to fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org