You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/30 06:10:52 UTC
[GitHub] [shardingsphere-elasticjob] gzdzss opened a new pull request #1680: Fix validateJobErrorHandlerProperties
gzdzss opened a new pull request #1680:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1680
Fixes #1679.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1680: Fix validateJobErrorHandlerProperties
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1680:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1680#issuecomment-719276988
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680?src=pr&el=h1) Report
> Merging [#1680](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/147d85269e4ab8a5997c20fe66741e8b36e7e5c9?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1680 +/- ##
============================================
+ Coverage 86.08% 86.09% +0.01%
Complexity 105 105
============================================
Files 251 251
Lines 5677 5674 -3
Branches 875 875
============================================
- Hits 4887 4885 -2
+ Misses 476 475 -1
Partials 314 314
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lasticjob/lite/internal/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `77.27% <ø> (-1.40%)` | `0.00 <0.00> (ø)` | |
| [...asticjob/error/handler/JobErrorHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1lY29zeXN0ZW0vZWxhc3RpY2pvYi1lcnJvci1oYW5kbGVyL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci10eXBlL2VsYXN0aWNqb2ItZXJyb3ItaGFuZGxlci1nZW5lcmFsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2Vycm9yL2hhbmRsZXIvSm9iRXJyb3JIYW5kbGVyRmFjdG9yeS5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ite/internal/election/ElectionListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vRWxlY3Rpb25MaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `92.00% <0.00%> (-4.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `82.53% <0.00%> (+1.58%)` | `1.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680?src=pr&el=footer). Last update [147d852...6e225cb](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu closed pull request #1680: Fix validateJobErrorHandlerProperties
Posted by GitBox <gi...@apache.org>.
terrymanu closed pull request #1680:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org