You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/08/23 20:00:37 UTC
Review Request 68492: ATLAS-2836: Remove redundant encoding of vertex
property keys
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68492/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
Bugs: ATLAS-2836
https://issues.apache.org/jira/browse/ATLAS-2836
Repository: atlas
Description
-------
JanusGraph has RESERVED characters which are restricted as property keys.
RESERVED_CHARS = { '
{' , '}
', '"' };
Atlas encodes them before writing to vertex/edge. Lot of duplicate encoding is currently present. Encoding is costly operation and should be done only once. This JIRA will refactor and remove duplicate encoding.
Diffs
-----
common/src/main/java/org/apache/atlas/repository/Constants.java e4772d177
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 5e2e01004
repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 8e5a448ee
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java a3398ac32
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 16b193ddd
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java d9cf2e1df
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java 4082fdee6
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 65c1e77d1
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityDefStoreV2.java f427136cf
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java a6a3237f8
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2.java bc03aebc7
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java 5372d9b9a
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 129bb55c2
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 1c679c786
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 8a2568954
Diff: https://reviews.apache.org/r/68492/diff/1/
Testing
-------
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/603/console
Thanks,
Sarath Subramanian
Re: Review Request 68492: ATLAS-2836: Remove redundant encoding of
vertex property keys
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68492/#review207852
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 23, 2018, 8 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68492/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2018, 8 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2836
> https://issues.apache.org/jira/browse/ATLAS-2836
>
>
> Repository: atlas
>
>
> Description
> -------
>
> JanusGraph has RESERVED characters which are restricted as property keys.
>
> RESERVED_CHARS = { '
>
> {' , '}
> ', '"' };
>
> Atlas encodes them before writing to vertex/edge. Lot of duplicate encoding is currently present. Encoding is costly operation and should be done only once. This JIRA will refactor and remove duplicate encoding.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/atlas/repository/Constants.java e4772d177
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 5e2e01004
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 8e5a448ee
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java a3398ac32
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java 16b193ddd
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1.java d9cf2e1df
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java 4082fdee6
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java 65c1e77d1
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityDefStoreV2.java f427136cf
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java a6a3237f8
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2.java bc03aebc7
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java 5372d9b9a
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 129bb55c2
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 1c679c786
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java 8a2568954
>
>
> Diff: https://reviews.apache.org/r/68492/diff/1/
>
>
> Testing
> -------
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/604/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>